Before simplifying the factory

test/test_simplified_access.py

@@ -10,11 +10,15 @@ from simplified_access import (
     CustomerData, 
     CustomerFactory, 
     ResGuestFactory,
+    HotelReservationIdData,
+    HotelReservationIdFactory,
     PhoneTechType,
     NotifCustomer,
     RetrieveCustomer,
     NotifResGuests,
-    RetrieveResGuests
+    RetrieveResGuests,
+    NotifHotelReservationId,
+    RetrieveHotelReservationId
 )
 
 
@@ -53,6 +57,25 @@ def minimal_customer_data():
     )
 
 
+@pytest.fixture
+def sample_hotel_reservation_id_data():
+    """Fixture providing sample hotel reservation ID data for testing."""
+    return HotelReservationIdData(
+        res_id_type="123",
+        res_id_value="RESERVATION-456",
+        res_id_source="HOTEL_SYSTEM",
+        res_id_source_context="BOOKING_ENGINE"
+    )
+
+
+@pytest.fixture
+def minimal_hotel_reservation_id_data():
+    """Fixture providing minimal hotel reservation ID data (only required fields)."""
+    return HotelReservationIdData(
+        res_id_type="999"
+    )
+
+
 class TestCustomerData:
     """Test the CustomerData dataclass."""
     
@@ -213,6 +236,73 @@ class TestCustomerFactory:
         assert customer.telephone[2].phone_tech_type == "5"  # MOBILE
 
 
+class TestHotelReservationIdData:
+    """Test the HotelReservationIdData dataclass."""
+    
+    def test_hotel_reservation_id_data_creation_full(self, sample_hotel_reservation_id_data):
+        """Test creating HotelReservationIdData with all fields."""
+        assert sample_hotel_reservation_id_data.res_id_type == "123"
+        assert sample_hotel_reservation_id_data.res_id_value == "RESERVATION-456"
+        assert sample_hotel_reservation_id_data.res_id_source == "HOTEL_SYSTEM"
+        assert sample_hotel_reservation_id_data.res_id_source_context == "BOOKING_ENGINE"
+    
+    def test_hotel_reservation_id_data_creation_minimal(self, minimal_hotel_reservation_id_data):
+        """Test creating HotelReservationIdData with only required fields."""
+        assert minimal_hotel_reservation_id_data.res_id_type == "999"
+        assert minimal_hotel_reservation_id_data.res_id_value is None
+        assert minimal_hotel_reservation_id_data.res_id_source is None
+        assert minimal_hotel_reservation_id_data.res_id_source_context is None
+
+
+class TestHotelReservationIdFactory:
+    """Test the HotelReservationIdFactory class."""
+    
+    def test_create_notif_hotel_reservation_id_full(self, sample_hotel_reservation_id_data):
+        """Test creating a NotifHotelReservationId with full data."""
+        reservation_id = HotelReservationIdFactory.create_notif_hotel_reservation_id(sample_hotel_reservation_id_data)
+        
+        assert isinstance(reservation_id, NotifHotelReservationId)
+        assert reservation_id.res_id_type == "123"
+        assert reservation_id.res_id_value == "RESERVATION-456"
+        assert reservation_id.res_id_source == "HOTEL_SYSTEM"
+        assert reservation_id.res_id_source_context == "BOOKING_ENGINE"
+    
+    def test_create_retrieve_hotel_reservation_id_full(self, sample_hotel_reservation_id_data):
+        """Test creating a RetrieveHotelReservationId with full data."""
+        reservation_id = HotelReservationIdFactory.create_retrieve_hotel_reservation_id(sample_hotel_reservation_id_data)
+        
+        assert isinstance(reservation_id, RetrieveHotelReservationId)
+        assert reservation_id.res_id_type == "123"
+        assert reservation_id.res_id_value == "RESERVATION-456"
+        assert reservation_id.res_id_source == "HOTEL_SYSTEM"
+        assert reservation_id.res_id_source_context == "BOOKING_ENGINE"
+    
+    def test_create_hotel_reservation_id_minimal(self, minimal_hotel_reservation_id_data):
+        """Test creating hotel reservation IDs with minimal data."""
+        notif_reservation_id = HotelReservationIdFactory.create_notif_hotel_reservation_id(minimal_hotel_reservation_id_data)
+        retrieve_reservation_id = HotelReservationIdFactory.create_retrieve_hotel_reservation_id(minimal_hotel_reservation_id_data)
+        
+        for reservation_id in [notif_reservation_id, retrieve_reservation_id]:
+            assert reservation_id.res_id_type == "999"
+            assert reservation_id.res_id_value is None
+            assert reservation_id.res_id_source is None
+            assert reservation_id.res_id_source_context is None
+    
+    def test_from_notif_hotel_reservation_id_roundtrip(self, sample_hotel_reservation_id_data):
+        """Test converting NotifHotelReservationId back to HotelReservationIdData."""
+        reservation_id = HotelReservationIdFactory.create_notif_hotel_reservation_id(sample_hotel_reservation_id_data)
+        converted_data = HotelReservationIdFactory.from_notif_hotel_reservation_id(reservation_id)
+        
+        assert converted_data == sample_hotel_reservation_id_data
+    
+    def test_from_retrieve_hotel_reservation_id_roundtrip(self, sample_hotel_reservation_id_data):
+        """Test converting RetrieveHotelReservationId back to HotelReservationIdData."""
+        reservation_id = HotelReservationIdFactory.create_retrieve_hotel_reservation_id(sample_hotel_reservation_id_data)
+        converted_data = HotelReservationIdFactory.from_retrieve_hotel_reservation_id(reservation_id)
+        
+        assert converted_data == sample_hotel_reservation_id_data
+
+
 class TestResGuestFactory:
     """Test the ResGuestFactory class."""
     
@@ -313,6 +403,17 @@ class TestIntegration:
         assert retrieve_customer.person_name.given_name == retrieve_from_res_guests.person_name.given_name
         assert retrieve_customer.person_name.surname == retrieve_from_res_guests.person_name.surname
     
+    def test_hotel_reservation_id_factories_produce_same_data(self, sample_hotel_reservation_id_data):
+        """Test that both HotelReservationId factories produce equivalent results."""
+        notif_reservation_id = HotelReservationIdFactory.create_notif_hotel_reservation_id(sample_hotel_reservation_id_data)
+        retrieve_reservation_id = HotelReservationIdFactory.create_retrieve_hotel_reservation_id(sample_hotel_reservation_id_data)
+        
+        # Both should have the same field values
+        assert notif_reservation_id.res_id_type == retrieve_reservation_id.res_id_type
+        assert notif_reservation_id.res_id_value == retrieve_reservation_id.res_id_value
+        assert notif_reservation_id.res_id_source == retrieve_reservation_id.res_id_source
+        assert notif_reservation_id.res_id_source_context == retrieve_reservation_id.res_id_source_context
+    
     def test_complex_customer_workflow(self):
         """Test a complex workflow with multiple operations."""
         # Create original data
@@ -342,6 +443,29 @@ class TestIntegration:
         notif_extracted = ResGuestFactory.extract_primary_customer(notif_res_guests)
         retrieve_extracted = ResGuestFactory.extract_primary_customer(retrieve_res_guests)
         
+        # All should be equal
+        assert original_data == notif_extracted
+        assert original_data == retrieve_extracted
+        assert notif_extracted == retrieve_extracted
+    
+    def test_complex_hotel_reservation_id_workflow(self):
+        """Test a complex workflow with HotelReservationId operations."""
+        # Create original reservation ID data
+        original_data = HotelReservationIdData(
+            res_id_type="456",
+            res_id_value="COMPLEX-RESERVATION-789",
+            res_id_source="INTEGRATION_SYSTEM",
+            res_id_source_context="API_CALL"
+        )
+        
+        # Create HotelReservationId for both types
+        notif_reservation_id = HotelReservationIdFactory.create_notif_hotel_reservation_id(original_data)
+        retrieve_reservation_id = HotelReservationIdFactory.create_retrieve_hotel_reservation_id(original_data)
+        
+        # Extract data back from both
+        notif_extracted = HotelReservationIdFactory.from_notif_hotel_reservation_id(notif_reservation_id)
+        retrieve_extracted = HotelReservationIdFactory.from_retrieve_hotel_reservation_id(retrieve_reservation_id)
+        
         # All should be equal
         assert original_data == notif_extracted
         assert original_data == retrieve_extracted