AlpineBitsfactory. Not necessarily a great idea though

test/test_simplified_access.py

@@ -12,7 +12,9 @@ from simplified_access import (
     ResGuestFactory,
     HotelReservationIdData,
     HotelReservationIdFactory,
+    AlpineBitsFactory,
     PhoneTechType,
+    OtaMessageType,
     NotifCustomer,
     RetrieveCustomer,
     NotifResGuests,
@@ -381,6 +383,141 @@ class TestPhoneTechType:
         assert PhoneTechType.MOBILE.value == "5"
 
 
+class TestAlpineBitsFactory:
+    """Test the unified AlpineBitsFactory class."""
+    
+    def test_create_customer_notif(self, sample_customer_data):
+        """Test creating customer using unified factory for NOTIF."""
+        customer = AlpineBitsFactory.create(sample_customer_data, OtaMessageType.NOTIF)
+        assert isinstance(customer, NotifCustomer)
+        assert customer.person_name.given_name == "John"
+        assert customer.person_name.surname == "Doe"
+    
+    def test_create_customer_retrieve(self, sample_customer_data):
+        """Test creating customer using unified factory for RETRIEVE."""
+        customer = AlpineBitsFactory.create(sample_customer_data, OtaMessageType.RETRIEVE)
+        assert isinstance(customer, RetrieveCustomer)
+        assert customer.person_name.given_name == "John"
+        assert customer.person_name.surname == "Doe"
+    
+    def test_create_hotel_reservation_id_notif(self, sample_hotel_reservation_id_data):
+        """Test creating hotel reservation ID using unified factory for NOTIF."""
+        reservation_id = AlpineBitsFactory.create(sample_hotel_reservation_id_data, OtaMessageType.NOTIF)
+        assert isinstance(reservation_id, NotifHotelReservationId)
+        assert reservation_id.res_id_type == "123"
+        assert reservation_id.res_id_value == "RESERVATION-456"
+    
+    def test_create_hotel_reservation_id_retrieve(self, sample_hotel_reservation_id_data):
+        """Test creating hotel reservation ID using unified factory for RETRIEVE."""
+        reservation_id = AlpineBitsFactory.create(sample_hotel_reservation_id_data, OtaMessageType.RETRIEVE)
+        assert isinstance(reservation_id, RetrieveHotelReservationId)
+        assert reservation_id.res_id_type == "123"
+        assert reservation_id.res_id_value == "RESERVATION-456"
+    
+    def test_create_res_guests_notif(self, sample_customer_data):
+        """Test creating ResGuests using unified factory for NOTIF."""
+        res_guests = AlpineBitsFactory.create_res_guests(sample_customer_data, OtaMessageType.NOTIF)
+        assert isinstance(res_guests, NotifResGuests)
+        customer = res_guests.res_guest.profiles.profile_info.profile.customer
+        assert customer.person_name.given_name == "John"
+    
+    def test_create_res_guests_retrieve(self, sample_customer_data):
+        """Test creating ResGuests using unified factory for RETRIEVE."""
+        res_guests = AlpineBitsFactory.create_res_guests(sample_customer_data, OtaMessageType.RETRIEVE)
+        assert isinstance(res_guests, RetrieveResGuests)
+        customer = res_guests.res_guest.profiles.profile_info.profile.customer
+        assert customer.person_name.given_name == "John"
+    
+    def test_extract_data_from_customer(self, sample_customer_data):
+        """Test extracting data from customer objects."""
+        # Create both types and extract data back
+        notif_customer = AlpineBitsFactory.create(sample_customer_data, OtaMessageType.NOTIF)
+        retrieve_customer = AlpineBitsFactory.create(sample_customer_data, OtaMessageType.RETRIEVE)
+        
+        notif_extracted = AlpineBitsFactory.extract_data(notif_customer)
+        retrieve_extracted = AlpineBitsFactory.extract_data(retrieve_customer)
+        
+        assert notif_extracted == sample_customer_data
+        assert retrieve_extracted == sample_customer_data
+    
+    def test_extract_data_from_hotel_reservation_id(self, sample_hotel_reservation_id_data):
+        """Test extracting data from hotel reservation ID objects."""
+        # Create both types and extract data back
+        notif_res_id = AlpineBitsFactory.create(sample_hotel_reservation_id_data, OtaMessageType.NOTIF)
+        retrieve_res_id = AlpineBitsFactory.create(sample_hotel_reservation_id_data, OtaMessageType.RETRIEVE)
+        
+        notif_extracted = AlpineBitsFactory.extract_data(notif_res_id)
+        retrieve_extracted = AlpineBitsFactory.extract_data(retrieve_res_id)
+        
+        assert notif_extracted == sample_hotel_reservation_id_data
+        assert retrieve_extracted == sample_hotel_reservation_id_data
+    
+    def test_extract_data_from_res_guests(self, sample_customer_data):
+        """Test extracting data from ResGuests objects."""
+        # Create both types and extract data back
+        notif_res_guests = AlpineBitsFactory.create_res_guests(sample_customer_data, OtaMessageType.NOTIF)
+        retrieve_res_guests = AlpineBitsFactory.create_res_guests(sample_customer_data, OtaMessageType.RETRIEVE)
+        
+        notif_extracted = AlpineBitsFactory.extract_data(notif_res_guests)
+        retrieve_extracted = AlpineBitsFactory.extract_data(retrieve_res_guests)
+        
+        assert notif_extracted == sample_customer_data
+        assert retrieve_extracted == sample_customer_data
+    
+    def test_unsupported_data_type_error(self):
+        """Test that unsupported data types raise ValueError."""
+        with pytest.raises(ValueError, match="Unsupported data type"):
+            AlpineBitsFactory.create("invalid_data", OtaMessageType.NOTIF)
+    
+    def test_unsupported_object_type_error(self):
+        """Test that unsupported object types raise ValueError in extract_data."""
+        with pytest.raises(ValueError, match="Unsupported object type"):
+            AlpineBitsFactory.extract_data("invalid_object")
+    
+    def test_complete_workflow_with_unified_factory(self):
+        """Test a complete workflow using only the unified factory."""
+        # Original data
+        customer_data = CustomerData(
+            given_name="Unified",
+            surname="Factory",
+            email_address="unified@factory.com",
+            phone_numbers=[("+1234567890", PhoneTechType.MOBILE)]
+        )
+        
+        reservation_data = HotelReservationIdData(
+            res_id_type="999",
+            res_id_value="UNIFIED-TEST"
+        )
+        
+        # Create using unified factory
+        customer_notif = AlpineBitsFactory.create(customer_data, OtaMessageType.NOTIF)
+        customer_retrieve = AlpineBitsFactory.create(customer_data, OtaMessageType.RETRIEVE)
+        
+        res_id_notif = AlpineBitsFactory.create(reservation_data, OtaMessageType.NOTIF)
+        res_id_retrieve = AlpineBitsFactory.create(reservation_data, OtaMessageType.RETRIEVE)
+        
+        res_guests_notif = AlpineBitsFactory.create_res_guests(customer_data, OtaMessageType.NOTIF)
+        res_guests_retrieve = AlpineBitsFactory.create_res_guests(customer_data, OtaMessageType.RETRIEVE)
+        
+        # Extract everything back
+        extracted_customer_from_notif = AlpineBitsFactory.extract_data(customer_notif)
+        extracted_customer_from_retrieve = AlpineBitsFactory.extract_data(customer_retrieve)
+        
+        extracted_res_id_from_notif = AlpineBitsFactory.extract_data(res_id_notif)
+        extracted_res_id_from_retrieve = AlpineBitsFactory.extract_data(res_id_retrieve)
+        
+        extracted_from_res_guests_notif = AlpineBitsFactory.extract_data(res_guests_notif)
+        extracted_from_res_guests_retrieve = AlpineBitsFactory.extract_data(res_guests_retrieve)
+        
+        # Verify everything matches
+        assert extracted_customer_from_notif == customer_data
+        assert extracted_customer_from_retrieve == customer_data
+        assert extracted_res_id_from_notif == reservation_data
+        assert extracted_res_id_from_retrieve == reservation_data
+        assert extracted_from_res_guests_notif == customer_data
+        assert extracted_from_res_guests_retrieve == customer_data
+
+
 class TestIntegration:
     """Integration tests combining both factories."""