Cleanup

src/alpine_bits_python/api.py

@@ -25,7 +25,7 @@ from .alpinebits_server import (
     AlpineBitsServer,
     Version,
 )
-from .auth import generate_api_key, generate_unique_id, validate_api_key
+from .auth import generate_unique_id, validate_api_key
 from .config_loader import load_config
 from .db import Base, get_database_url
 from .db import Customer as DBCustomer
@@ -57,7 +57,7 @@ class EventDispatcher:
         self.listeners[event_name].append(func)
 
     def register_hotel_listener(self, event_name, hotel_code, func):
-        """Register a listener for a specific hotel"""
+        """Register a listener for a specific hotel."""
         self.hotel_listeners[f"{event_name}:{hotel_code}"].append(func)
 
     async def dispatch(self, event_name, *args, **kwargs):
@@ -65,7 +65,7 @@ class EventDispatcher:
             await func(*args, **kwargs)
 
     async def dispatch_for_hotel(self, event_name, hotel_code, *args, **kwargs):
-        """Dispatch event only to listeners registered for specific hotel"""
+        """Dispatch event only to listeners registered for specific hotel."""
         key = f"{event_name}:{hotel_code}"
         for func in self.hotel_listeners[key]:
             await func(*args, **kwargs)
@@ -162,7 +162,7 @@ async def push_listener(customer: DBCustomer, reservation: DBReservation, hotel)
             )
 
     except Exception as e:
-        _LOGGER.error(f"Push event failed for hotel {hotel['hotel_id']}: {e}")
+        _LOGGER.exception(f"Push event failed for hotel {hotel['hotel_id']}: {e}")
         # Optionally implement retry logic here@asynccontextmanager
 
 
@@ -258,7 +258,7 @@ app.add_middleware(
 @api_router.get("/")
 @limiter.limit(DEFAULT_RATE_LIMIT)
 async def root(request: Request):
-    """Health check endpoint"""
+    """Health check endpoint."""
     return {
         "message": "Wix Form Handler API is running",
         "timestamp": datetime.now().isoformat(),
@@ -275,7 +275,7 @@ async def root(request: Request):
 @api_router.get("/health")
 @limiter.limit(DEFAULT_RATE_LIMIT)
 async def health_check(request: Request):
-    """Detailed health check"""
+    """Detailed health check."""
     return {
         "status": "healthy",
         "timestamp": datetime.now().isoformat(),
@@ -345,7 +345,7 @@ async def process_wix_form_submission(request: Request, data: dict[str, Any], db
     last_name = contact_info.get("name", {}).get("last")
     email = contact_info.get("email")
     phone_number = contact_info.get("phones", [{}])[0].get("e164Phone")
-    locale = contact_info.get("locale", "de-de")
+    contact_info.get("locale", "de-de")
     contact_id = contact_info.get("contactId")
 
     name_prefix = data.get("field:anrede")
@@ -377,7 +377,7 @@ async def process_wix_form_submission(request: Request, data: dict[str, Any], db
     num_children = int(data.get("field:anzahl_kinder") or 0)
     children_ages = []
     if num_children > 0:
-        for k in data.keys():
+        for k in data:
             if k.startswith("field:alter_kind_"):
                 try:
                     age = int(data[k])
@@ -548,7 +548,7 @@ async def handle_wix_form(
     try:
         return await process_wix_form_submission(request, data, db_session)
     except Exception as e:
-        _LOGGER.error("Error in handle_wix_form: %s", e)
+        _LOGGER.exception("Error in handle_wix_form: %s", e)
         # log stacktrace
         import traceback
 
@@ -563,12 +563,13 @@ async def handle_wix_form_test(
     request: Request, data: dict[str, Any], db_session=Depends(get_async_session)
 ):
     """Test endpoint to verify the API is working with raw JSON data.
+
     No authentication required for testing purposes.
     """
     try:
         return await process_wix_form_submission(request, data, db_session)
     except Exception as e:
-        _LOGGER.error(f"Error in handle_wix_form_test: {e!s}")
+        _LOGGER.exception(f"Error in handle_wix_form_test: {e!s}")
         raise HTTPException(status_code=500, detail="Error processing test data")
 
 
@@ -666,30 +667,6 @@ async def handle_xml_upload(
         raise HTTPException(status_code=500, detail="Error processing XML upload")
 
 
-# UNUSED
-@api_router.post("/admin/generate-api-key")
-@limiter.limit("5/hour")  # Very restrictive for admin operations
-async def generate_new_api_key(
-    request: Request, admin_key: str = Depends(validate_api_key)
-):
-    """Admin endpoint to generate new API keys.
-    Requires admin API key and is heavily rate limited.
-    """
-    if admin_key != "admin-key":
-        raise HTTPException(status_code=403, detail="Admin access required")
-
-    new_key = generate_api_key()
-    _LOGGER.info(f"Generated new API key (requested by: {admin_key})")
-
-    return {
-        "status": "success",
-        "message": "New API key generated",
-        "api_key": new_key,
-        "timestamp": datetime.now().isoformat(),
-        "note": "Store this key securely - it won't be shown again",
-    }
-
-
 # TODO Bit sketchy. May need requests-toolkit in the future
 def parse_multipart_data(content_type: str, body: bytes) -> dict[str, Any]:
     """Parse multipart/form-data from raw request body.
@@ -861,7 +838,7 @@ async def alpinebits_server_handshake(
         # Re-raise HTTP exceptions (auth errors, etc.)
         raise
     except Exception as e:
-        _LOGGER.error(f"Error in AlpineBits handshake: {e!s}")
+        _LOGGER.exception(f"Error in AlpineBits handshake: {e!s}")
         raise HTTPException(status_code=500, detail="Internal server error")